Nokia srl prompt stripping #3531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeffkala Added some tests and converted the one method to a private method (as more consistent with standard Netmiko behavior). |
hellt
reviewed
Nov 8, 2024
netmiko/nokia/nokia_srl.py
Outdated
| def _strip_context_items(self, a_string: str) -> str: | ||
| """Strip NokiaSRL-specific output. | ||
|
|
||
| Nokia will put extra context is line 1 of the prompt, such as: |
There was a problem hiding this comment.
Suggested change
| Nokia will put extra context is line 1 of the prompt, such as: | |
| Nokia will put extra context in the 1st line of the prompt, such as: |
hellt
reviewed
Nov 8, 2024
netmiko/nokia/nokia_srl.py
Outdated
| @@ -53,6 +53,32 @@ def session_preparation(self) -> None: | |||
| self.disable_paging(command=command, cmd_verify=True, pattern=r"#") | |||
| self.set_base_prompt() | |||
|
|
|||
| def strip_prompt(self, *args: Any, **kwargs: Any) -> str: | |||
| """Strip the line1 of multiline prompt from the output.""" | |||
There was a problem hiding this comment.
is this statement correct about the 1st line? Shouldn't the strip tackle the two lines?
There was a problem hiding this comment.
Still calling super which I'd assume would strip the original prompt.
There was a problem hiding this comment.
I updated the docstrings, the super() call will get rid of A:srl1#.
The _strip_context_items call will get rid of things like --{ running }...
There was a problem hiding this comment.
ah, I see, by "prompt" you mean only one line of the SR Linux prompt.
Ok, lgtm
ktbyers
force-pushed
the
nokiasrl_prompt_strip
branch
from
2bdb523
to
25be4a9
Compare
jeffkala
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.